Attention is currently required from: laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35044?usp=email )
Change subject: soft_uart: implement the transmitter ......................................................................
Patch Set 2:
(1 comment)
File src/core/soft_uart.c:
https://gerrit.osmocom.org/c/libosmocore/+/35044/comment/e0a3ed30_c7f70872 PS2, Line 209: size_t osmo_soft_uart_tx(struct osmo_soft_uart *suart,
how does this reject any buffer overflows? It is difficult to manage transmission with a buffer, IM […]
For the record, we further discussed this proposal in the IRC and decided to go for it. Regarding the buffer overflow protection, note the `OSMO_MIN` in this function. The caller is currently expected to check the returned value, which can be equal to or less than the `data_len`.