Attention is currently required from: pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/28002
)
Change subject: paging: Take into account extra delay of all paging groups in BSC queue
......................................................................
Patch Set 3: Code-Review+1
(3 comments)
File src/osmo-bsc/paging.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28002/comment/cfc17c6a_5496a2c6
PS2, Line 347: reqs_before_same_pgroup
(group vs pgroup inconsistent?)
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/28002/comment/4fd96358_4a87d942
PS2, Line 664: If don't
"If we don't"?
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/28002/comment/ce7b2ceb_b0cd74a1
PS2, Line 671: GSM51_MFRAME_DURATION_us
Yes. […]
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/28002
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib55f947c5d3490b27e1d08d39392992919512f9a
Gerrit-Change-Number: 28002
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 03 May 2022 08:51:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment