Attention is currently required from: laforge.

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37511?usp=email )

The change is no longer submittable: Code-Review is unsatisfied now.

Change subject: osmo-smdpp + es9p_client: HTTP status 204 is used for handleNotification ......................................................................

Patch Set 3: Code-Review+1

(2 comments)

Patchset:

PS3: I have tried current master and this patchset in a real world setup and in both cases I see that if the transactionId is unknown by osmo-smpdpp that 200 with an empty body is returned. I am still not sure what the problem really (the transactionId sould be known) is, but I think the combination of 200 + empty body should not occur in any case.

File osmo-smdpp.py:

https://gerrit.osmocom.org/c/pysim/+/37511/comment/d9b3f5c1_7df2805c PS3, Line 494: return I still see that osmo-smdpp.py is sending status 200 in case it does not find the transactionId here. I wonder if it makes sense to do the setResponseCode earlier?