Attention is currently required from: laforge.
Patch set 3:Code-Review +1
The change is no longer submittable: Code-Review is unsatisfied now.
2 comments:
Patchset:
I have tried current master and this patchset in a real world setup and in both cases I see that if the transactionId is unknown by osmo-smpdpp that 200 with an empty body is returned. I am still not sure what the problem really (the transactionId sould be known) is, but I think the combination of 200 + empty body should not occur in any case.
File osmo-smdpp.py:
Patch Set #3, Line 494: return
I still see that osmo-smdpp.py is sending status 200 in case it does not find the transactionId here. I wonder if it makes sense to do the setResponseCode earlier?
To view, visit change 37511. To unsubscribe, or for help writing mail filters, visit settings.