Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27356 )
Change subject: bitvec2freq_list(): fix handling of E-GSM ARFCNs
......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1:
also, missing Related: SYS#....
What? It's
there. Next line after the 'Change-Id'.
File src/osmo-bsc/system_information.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27356/comment/9c82b989_d970bae6
PS1, Line 508: && bts->c0->arfcn >= 1 && bts->c0->arfcn
<= 124)
: pgsm = true;
isn't this the true bug? PGSM is primary GSM, and
not E-GSM 900. […]
This is also an option, yes. Currently we assume that all ARFCNs
are in P-GSM, and fall-back to other encodings if we find an out-of-range (i.e. E-GSM)
value.
https://gerrit.osmocom.org/c/osmo-bsc/+/27356/comment/34f9fd24_f1d4a737
PS1, Line 522: /
how are we attempting to use a different format here?
we return an error.
I am adding an 'if' statement right after the
'for' loop (see line 532), which checks rc. If it's 0, then we return 0. If
not, then we fall-back to other encoding formats. I can change it to do 'goto
foo_bar' instead of setting rc to -ERANGE.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/27356
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I17739e6845cd84e2a81bc406dd532541f7c52cb6
Gerrit-Change-Number: 27356
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 02 Mar 2022 09:21:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment