Attention is currently required from: msuraev. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31362 ) Change subject: pcu_l1_if: get rid of l1if checks ...................................................................... Patch Set 2: (1 comment) File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31362/comment/4e67878e_943266d8 PS2, Line 219: msg->data, msg->len); This patch changes the code behavior a bit: Even when fl1h is NULL we still go ahead. l1if_pdch_req checks fl1h so we won't crash, the msg buffer is freed and we return without doing anything. In the old code we would continue with the pcu_tx_data_req and behave like a PCU with no direct PHY support at all. I am not sure if this is good. However, I think the new behavior is better since in case a PHY is selected and for some reason couldn't open properly so that fl1h is NULL it shouldn't fall back to the behavior of a PCU without direct PHY access. Its not even clear if the other side supports the indirect way via pcu_sock at all. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31362 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I54c5de04382e0bd0dbbf233eaffb403fc492d070 Gerrit-Change-Number: 31362 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Feb 2023 12:38:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment