Attention is currently required from: msuraev.

View Change

1 comment:

• File src/pcu_l1_if.cpp:

  • Patch Set #2, Line 219: msg->data, msg->len);

    This patch changes the code behavior a bit: Even when fl1h is NULL we still go ahead. l1if_pdch_req checks fl1h so we won't crash, the msg buffer is freed and we return without doing anything. In the old code we would continue with the pcu_tx_data_req and behave like a PCU with no direct PHY support at all. I am not sure if this is good.

    However, I think the new behavior is better since in case a PHY is selected and for some reason couldn't open properly so that fl1h is NULL it shouldn't fall back to the behavior of a PCU without direct PHY access. Its not even clear if the other side supports the indirect way via pcu_sock at all.

To view, visit change 31362. To unsubscribe, or for help writing mail filters, visit settings.