Attention is currently required from: neels, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/40632?usp=email ) Change subject: ran_peer: Add specific API to free object ...................................................................... Patch Set 2: Code-Review-2 (4 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/40632/comment/e6ee89c6_0286c34b?usp… : PS2, Line 11: Swap the talloc tree parentship to have the fi be a child of the object, : which simplifies tear down triggered by FSM cleanup. From the hierarchical point of view, I find it logical the way it is: the FSM instance's private data belongs to that instance and is a child of that instance. https://gerrit.osmocom.org/c/osmo-msc/+/40632/comment/d9143ed3_9b608f4a?usp… : PS2, Line 14: Apparently the object is not being freed anywhere It's being free()d automatically by talloc, since it's allocated as a child of the fi: ``` rp = talloc_zero(fi, struct ran_peer); ``` With your patch the `struct ran_peer` is no longer free()ed because nobody calls the new `ran_peer_free()` API. File include/osmocom/msc/ran_peer.h: https://gerrit.osmocom.org/c/osmo-msc/+/40632/comment/6ab938f3_57c642c6?usp… : PS2, Line 109: ran_peer_discard_all_conns How is this related to this patch? Why exposing this API? File src/libmsc/ran_peer.c: https://gerrit.osmocom.org/c/osmo-msc/+/40632/comment/e2fc2130_815dc69b?usp… : PS2, Line 79: ran_peer_free You're adding this new API, but it's not being called anywhere. Nor it's declared in a public header. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40632?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I721de21a68a4e336ae508a995e3cfcca05d57efe Gerrit-Change-Number: 40632 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Jul 2025 08:29:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes