Attention is currently required from: pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32536 )
Change subject: osmo_io: Add io_uring backend ......................................................................
Patch Set 12:
(2 comments)
File tests/osmo_io/osmo_io_test.c:
https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/dc3331f5_1340909e PS12, Line 99: for (int i = 0; i < 128; i++)
why is this needed?
In io_uring there is still a queue submitted for the read/receive call. After osmo_iofd_free() this read completes (with an error) / is aborted and we return the queue entry and actually free the osmo_io_fd.
(Without this leak sanitizer reports a mem leak.)
https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/c32950cc_455175a0 PS12, Line 155: osmo_select_main(1);
why is this needed?
see above
-
daniel