Attention is currently required from: laforge.

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38657?usp=email )

Change subject: pySim/transport add support for T=1 protocol and fix APDU/TPDU layer conflicts ......................................................................

Patch Set 2:

(2 comments)

File pySim/transport/__init__.py:

https://gerrit.osmocom.org/c/pysim/+/38657/comment/2193af2f_e7b49cf0?usp=ema... : PS1, Line 243: cl

I find the use of multiple inheritance here a bit confusing. Can we not simply have […]

Sure we can do that. Then let's have a LinkBase base class and a class LinkBaseTpdu that inherits from it. We inherit LinkBase directly in cases where the transport layer implementation works on APDU level. In cases where the transport layer implementation requires TPDUs, would inherit a class LinkBaseTpdu.

https://gerrit.osmocom.org/c/pysim/+/38657/comment/9f95ca15_28441478?usp=ema... : PS1, Line 320: __send_apdu_T1

I'm not actually sure there is anything T=1 specific here. It is just sending an APDU. […]

Yes, this is true, there is no T=1 specific stuff happening in the method. It just passes the APDUs as TPDUs transparently. we may call this method differently so that it is more generic. So should we add T15 support one day, we won't have to add a __send_apdu_T15 method which would be just a copy of __send_apdu_T1 then.