Attention is currently required from: lynxis lazus, pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/41362?usp=email )
Change subject: tests/testsuite.at: fix invalid if-endif syntax ......................................................................
Patch Set 1:
(1 comment)
File tests/testsuite.at:
https://gerrit.osmocom.org/c/libosmocore/+/41362/comment/2d0fb0c4_e2314df4?u... : PS1, Line 86: AT_SKIP_IF([test ! -e $abs_top_builddir/tests/msgfile/msgfile_test])
We seem to be already supporting this with a variable, see libosmocore/tests/testsuite.at: […]
@pespin@sysmocom.de if you grep for `ENABLE_URING`, for instance:
``` $ git grep -n ENABLE_URING tests/ tests/Makefile.am:765: $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) ENABLE_URING=$(ENABLE_URING) ENABLE_URING_TESTS=$(ENABLE_URING_TESTS) tests/Makefile.am:770: $(TESTSUITEFLAGS) ENABLE_URING=$(ENABLE_URING) ENABLE_URING_TESTS=$(ENABLE_URING_TESTS) tests/testsuite.at:564:AT_SKIP_IF([ test "$ENABLE_URING" != "yes" || test "$ENABLE_URING_TESTS" != "yes" ]) ```
you'll see that these two variables are manually passed to the testsuite script.
``` 763 check-local: atconfig $(TESTSUITE) 764 [ -e /proc/cpuinfo ] && cat /proc/cpuinfo 765 $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) ENABLE_URING=$(ENABLE_URING) ENABLE_URING_TESTS=$(ENABLE_URING_TESTS) 766 $(MAKE) $(AM_MAKEFLAGS) ext-tests 767 768 installcheck-local: atconfig $(TESTSUITE) 769 $(SHELL) '$(TESTSUITE)' AUTOTEST_PATH='$(bindir)' \ 770 $(TESTSUITEFLAGS) ENABLE_URING=$(ENABLE_URING) ENABLE_URING_TESTS=$(ENABLE_URING_TESTS)
```
This means we would need to pass `ENABLE_MSGFILE` (and the other `ENABLE_` variables) manually. IMO, checking if a binary is present is a lot simpler and less error-prone.
-
fixeria