Attention is currently required from: osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38480?usp=email )
Change subject: ggsn: use libosmocore tundev API to create apn tun device ......................................................................
Patch Set 3:
(1 comment)
File lib/tun.c:
https://gerrit.osmocom.org/c/osmo-ggsn/+/38480/comment/13ca6e19_ffe770db?usp... : PS3, Line 201: err_free_tundev:
Instead of duplicating these labels in the same function, maybe add separate functions for the now c […]
Yes, I was thinking about that too, but I preferred to keep it this way in this commit to make the change less drastic. I may submitt some follow-up patches doing some extra cleanup later on.