Attention is currently required from: pespin, msuraev.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/29303 )
Change subject: Don't manually create pid file
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
That's the only osmocom service which creates
pidfile manually. […]
I also think it's weird that one of our programs contains
code to generate a pid file but no others do. Either we want to do that, and then it
should be part of libosmocore to do it for all programs, or we don't do it.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/29303
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I86bcaedbc8cb1297476ad741eaa45585fea3c380
Gerrit-Change-Number: 29303
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 12 Sep 2022 07:12:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment