Attention is currently required from: falconia.

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/37797?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed: Verified-1 by Jenkins Builder

Change subject: tests: add unit test for osmo_hr_sid_classify() ......................................................................

tests: add unit test for osmo_hr_sid_classify()

The bit patterns used to construct this unit test originate from an experiment involving a Calypso GSM MS and a CMU200 test instrument configured to simulate radio conditions ranging from good to bad, as documented here:

https://osmocom.org/projects/retro-gsm/wiki/HRv1_error_flags

The resulting unit test proves correctness of osmo_hr_sid_classify() implementation not only "against itself" and against theoretical understanding of ETSI reference logic, but also by confirming a match between our computed classification and that produced by TI's DSP.

Related: OS#6036 Change-Id: I9944bb7d49b6fe004d4bfc7a3f70cfdb03d62614 --- M tests/Makefile.am A tests/codec/codec_hr_sid_test.c A tests/codec/codec_hr_sid_test.in A tests/codec/codec_hr_sid_test.ok M tests/testsuite.at 5 files changed, 259 insertions(+), 1 deletion(-)

git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/97/37797/2