Attention is currently required from: arehbein, fixeria, pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34526?usp=email )
Change subject: meas_feed: Use osmo_io instead of write queue ......................................................................
Patch Set 6:
(2 comments)
File src/osmo-bsc/meas_feed.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/34526/comment/8d79aec3_162f3443 PS6, Line 33: static struct meas_feed_state g_mfs = {.txqueue_max = MEAS_FEED_TXQUEUE_MAX_LEN_DEFAULT}; Not sure if we have preferred way in osmocom, but I'd prefer each initializer element on its own line.
``` static struct meas_feed_state g_mfs = { .txqueue_max = MEAS_FEED_TXQUEUE_MAX_LEN_DEFAULT, }; ```
https://gerrit.osmocom.org/c/osmo-bsc/+/34526/comment/f74ff94f_607a94b9 PS6, Line 133: struct osmo_io_ops meas_feed_oio = {.read_cb = NULL, .write_cb = meas_feed_noop_cb, Here as well
-
daniel