Attention is currently required from: arehbein, fixeria, pespin.

View Change

2 comments:

• File src/osmo-bsc/meas_feed.c:

  • Patch Set #6, Line 33: static struct meas_feed_state g_mfs = {.txqueue_max = MEAS_FEED_TXQUEUE_MAX_LEN_DEFAULT};

    Not sure if we have preferred way in osmocom, but I'd prefer each initializer element on its own line.

    ```
    static struct meas_feed_state g_mfs = {
      .txqueue_max = MEAS_FEED_TXQUEUE_MAX_LEN_DEFAULT,
      };
    ```

  • Patch Set #6, Line 133: struct osmo_io_ops meas_feed_oio = {.read_cb = NULL, .write_cb = meas_feed_noop_cb,

    Here as well

To view, visit change 34526. To unsubscribe, or for help writing mail filters, visit settings.