Change in osmo-pcu[master]: pdch: Introduce APIs to print PDCH name - gerrit-log

16 Dec 2022


      Attention is currently required from: pespin, fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30619 )
Change subject: pdch: Introduce APIs to print PDCH name
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/pdch.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/30619/comment/1e39a19d_aa8a51c9 
PS2, Line 1346: pdch_name_buf
...
I am happy you agreed with Neels on doing that in another project/context; I really don't want to do […]
Then I suggest doing OSMO_ASSERT here, so it's explicit.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30619
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: If18cb4a48237751e0dddede6793191b36dfe386d
Gerrit-Change-Number: 30619
Gerrit-PatchSet: 2
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Fri, 16 Dec 2022 14:05:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin pespin@sysmocom.de
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Gerrit-MessageType: comment