Attention is currently required from: dexter, laforge.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/34932?usp=email )
Change subject: runtime: refactor file selection methods select and select_file
......................................................................
Patch Set 1:
(4 comments)
File pySim/runtime.py:
https://gerrit.osmocom.org/c/pysim/+/34932/comment/67d5d0a2_2a4e2b04
PS1, Line 174:
Tabs should not be mixed with spaces. Please configure your editor to use spaces for
*.py.
https://gerrit.osmocom.org/c/pysim/+/34932/comment/b7c3a251_b80da082
PS1, Line 296: CardFile
`Optional[CardFile]`
https://gerrit.osmocom.org/c/pysim/+/34932/comment/b2f4ed6d_e27573d6
PS1, Line 298:
tabs vs spaces
https://gerrit.osmocom.org/c/pysim/+/34932/comment/db0bba04_ab29f17c
PS1, Line 375:
tabs vs spaces
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/34932?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9ae213f3b078983f3e6d4c11db38fdbe504c84f2
Gerrit-Change-Number: 34932
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 01 Nov 2023 09:37:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment