Attention is currently required from: osmith.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377?usp=email )

Change subject: AS loadsharing: Initial routing implementation based on extended-SLS ......................................................................

Patch Set 4:

(2 comments)

File include/osmocom/sigtran/osmo_ss7.h:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377/comment/144fd5c2_123b2e... : PS4, Line 129: internal

what do you mean with internal here?

"private". The only use of this function outside of libosmo-sccp is in osmo-bsc where we do really special things to reuse the SCCPLite IPA conn to multiplex the MGCP from/to the MSC, which is kinda layering violation. That code really needs to be looked at (I'll probably be doing that) and figure out the best approach since it's really a niche use case there.

Moreover, the existing osmo_ss7_route_lookup() doesn't allow providing a full route label to calculate the routing, which means it's more limited. I'll probably end up exporting the new ss7_instance_lookup_route() later on, but we can do that at a later point.

File src/osmo_ss7_combined_linkset.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377/comment/59aca7af_6dd513... : PS4, Line 166: struct osmo_ss7_route *current_rt(const struct osmo_ss7_combined_linkset *clset, const struct osmo_ss7_esls_entry *eslse)

clset is not uses in this function?

Acknowledged