Attention is currently required from: falconia.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/34448?usp=email )
Change subject: SMS over GSUP: implement vty config of SMSC routing ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2: Once s/del/free/, +1 from me.
File include/osmocom/hlr/hlr_sms.h:
https://gerrit.osmocom.org/c/osmo-hlr/+/34448/comment/a368c5f7_b860a266 PS2, Line 17: void smsc_del(struct hlr_smsc *smsc); we usually call these free as a counterpart of alloc. This also makes it clear by convention that passing NULL to it is allowed as a NOOP.
https://gerrit.osmocom.org/c/osmo-hlr/+/34448/comment/085ddeba_cacfda19 PS2, Line 29: void smsc_route_del(struct hlr_smsc_route *rt); free