Attention is currently required from: pespin, daniel, dexter. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106 )
Change subject: Add hnbgw tests ......................................................................
Patch Set 5: Code-Review+1
(5 comments)
File hnbgw/HNBGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/a2380a80_40655... PS5, Line 144: mgw_rtp_ip := "1.1.1.1", could use a private ip range
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/a363ba27_9ca74... PS5, Line 150: mgw_rtp_ip := "2.2.2.2", could use a private ip range
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/3d0a1d5e_f1446... PS5, Line 156: hnb_rtp_ip := "1.1.1.2", could use a private ip range
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/23a8b76d_bddd2... PS5, Line 158: cn_rtp_ip := "2.2.2.1", could use a private ip range
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/627a1afb_0582b... PS5, Line 622: f_sleep(10.0); 10 seconds are quite long. why do we need a sleep here?