Attention is currently required from: pespin, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30326 )
Change subject: mobile: add MNCC handler selection to settings ......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1:
Typo in commit message: extarnal
Done. Also fixed s/potentionally/potentially/.
File src/host/layer23/src/mobile/app_mobile.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30326/comment/50b67a02_8a8bb98a PS1, Line 249: ms->mncc_entity.sock_state = mncc_sock_init(ms, ms->settings.mncc_socket_path);
So sock_state is used only if mncc_handler is "EXTERNAL"? Then better put it under ms->mncc_entity. […]
There is a big room for improvements here, given that this project is not actively maintained since... idk how many years ago. I am not going to rework the existing mobile's structures unless it's really necessary. Feel free to submit a patch.
File src/host/layer23/src/mobile/vty_interface.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30326/comment/34677460_cbf31875 PS1, Line 1665: DEFUN(cfg_ms_no_mncc_handler, cfg_ms_no_mncc_handler_cmd,
ACK, specifying the default above in the description (like you did) should be enough for the user to […]
To stay consistent with the existing 'io-handler', which has both variants. I can remove the no-command if you guys insist, but honestly I see nothing wrong in having two variants.
-
fixeria