Attention is currently required from: jolly, neels, laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/33500
)
Change subject: ASCI: Allow usage of rtp_stream with other FSM
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-msc/+/33500/comment/b20e38b7_722a205e
PS6, Line 13: Drop the unused parent_call_leg member.
Removing the parant_call_leg is part of the patch, so
it does not depend on call_leg anymore. […]
Is it really worth sparing me from
having to discern different stuff while I review all your patches? IMHO yes of course 😊
let's merge this one as is, but I'd be glad if you take it into consideration for
next patches :)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/33500
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I0991927b6d00da08dfd455980645e68281a73a9e
Gerrit-Change-Number: 33500
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 06 Jul 2023 12:08:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment