neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27658 ) Change subject: bsc: as_Media_mgw: fail on DLCX ...................................................................... bsc: as_Media_mgw: fail on DLCX as_Media_mgw() is used to establish a voice stream. If a DLCX happens as part of that, that should be flagged as a problem. In fact the Mode Modify test with current osmo-bsc does exhibit a DLCX right upon the Assignment Complete message, which is a bug fixed in I5ab10ee7fd9c5d7608e8a06893881d990943feed. This patch now correctly flags this as a failure. Related: SYS#5916 Change-Id: I0633f60f09d58802f6be0238ef41a632d93a4327 --- M bsc/MSC_ConnectionHandler.ttcn 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/58/27658/1 diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn index a50b6f4..68a034b 100644 --- a/bsc/MSC_ConnectionHandler.ttcn +++ b/bsc/MSC_ConnectionHandler.ttcn @@ -383,6 +383,9 @@ var template MgcpMessage msg_mdcx := { command := tr_MDCX } + var template MgcpMessage msg_dlcx := { + command := tr_DLCX + } var template MgcpMessage msg_resp; [g_pars.aoip] MGCP.receive(tr_CRCX) -> value mgcp_cmd { @@ -422,6 +425,14 @@ repeat; } } + + [g_pars.aoip] MGCP.receive(tr_DLCX) { + setverdict(fail, "Unexpected DLCX received"); + } + + [not g_pars.aoip] MGCP_MULTI.receive(tr_MGCP_RecvFrom_any(msg_dlcx)) { + setverdict(fail, "Unexpected DLCX received"); + } } /* Altsteps for handling of media related commands. Can be activated by a given -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27658 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0633f60f09d58802f6be0238ef41a632d93a4327 Gerrit-Change-Number: 27658 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange