Attention is currently required from: pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33539 )
Change subject: PCU_Tests: verify that PacketCellChangeContine contains an ARFCN and BSIC ......................................................................
Patch Set 2:
(2 comments)
File pcu/PCU_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33539/comment/4b9674b9_f591e... PS1, Line 5368: f_rx_rlcmac_dl_block(dl_block, sched_fn);
why not passing this constructed cell_cfg_cont here in f_rx_rlcmac_dl_block() as it was before?
I need to modify the arfcn/bsic parameters before I pass the template.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33539/comment/5b7ddd1b_5d82a... PS1, Line 5370: cell_chg_cont.u.cell_chg_continue.arfcn_bsic_presence := '1'B
you can probably extend the f_rx_rlcmac_dl_block to have those passed params maybe.
I thought about doing this but then I noticed that it might be not so good to add three more parameters just for a single test. I think it is better to just modify the required bits here instead of adding more and more parameters. Especially those CSN.1 RLCMAC templates have a ton of variations.
(This does not mean that it is technically impossible to add arfcn_bsic_present,arfcn,bsic parameters to the template, but I Think it won't look good.)