Attention is currently required from: laforge, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/34223 )
Change subject: osmo_ortp: register a PayloadType for RTP_PT_CSDATA ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/trau/osmo_ortp.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/34223/comment/e3d2f363_d5075621 PS1, Line 42: static PayloadType *payload_type_clearmode; I wonder why do we need all these static variables taking memory if they are not really used at all after create_payload_types() finishes....
https://gerrit.osmocom.org/c/libosmo-abis/+/34223/comment/4894211b_e31f4e59 PS1, Line 307: rtp_profile_set_payload(osmo_pt_profile, RTP_PT_AMR, &payload_type_amr); I'm unable to find where does payload_type_amr come from, I don't see it declared anywhere... :/
-
pespin