Attention is currently required from: pespin.
lynxis lazus has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/29907 )
Change subject: fsm: add ignore_invalid_event_mask bit-mask
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
IMHO this causes even more difficulties to understand
FSM code (both the FSM implementation and user […]
I find it very difficult to write
empty events in many states (both in the in_event_mask and within the state function). Or
having proxy functions which checks if the fsm might be in the right state to emit a
signal. Those log lines also confuses the user as we've seen in redmine tickets (e.g.
sgsn, ns layer).
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/29907
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id010ade76de83ccf428f2d18e9f85bcce1d1ea2c
Gerrit-Change-Number: 29907
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 28 Oct 2022 16:00:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment