Attention is currently required from: dexter.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36324?usp=email )

Change subject: msgb: Also copy msgb {dst, lchan, cb} during msgb_copy_* ......................................................................

Patch Set 1:

(1 comment)

File src/core/msgb.c:

https://gerrit.osmocom.org/c/libosmocore/+/36324/comment/904c5136_a3bd21eb PS1, Line 320: * and adjusts the pointers (incl l1h-l4h) accordingly. The cb part is not copied.

Now it is copied.

mh, ok. so the old function was *specified* not to copy the cb. That's weird. ususally msgb is modelled after kernel sk_buff, and there a skb_copy does copy the cb.

I guess the difficult question here is to detemine if any existing code is relying on the old behavior or not... If yes, then we should rather introduce a new function. I'll give it some more thought.