Attention is currently required from: osmith, laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/28059
)
Change subject: paging: Implement upper bound of 60s for dynamic T3113
......................................................................
Patch Set 3:
(1 comment)
File src/osmo-bsc/paging.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28059/comment/98c4f120_559225d4
PS3, Line 394: to, estimated_to);
I think it's not obvious why in most cases you
would have "expires in 5 seconds (estimated 5)". […]
I think the easiest
is leaving it as this. In generalthe expire is the same as the estimated, so nothing
confusing. In the event they are different, one will probably see several of them in near
time, and the expire will be always 60 with a higher estimate, so it's easy to infer
it tops at 60. Later on if we make the 60 configurable (if we deem necessary) we can
update the log to tell the user to tweak the VTY option.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/28059
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib8228f8485527d34794048a9927e62b6ec8d802a
Gerrit-Change-Number: 28059
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 10 May 2022 10:14:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment