Change in osmo-bsc-nat[master]: Reply to BSC's RESET with RESET ACK directly - gerrit-log

21 Mar 2022


      Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27471 )
Change subject: Reply to BSC's RESET with RESET ACK directly
......................................................................
Patch Set 4:
(1 comment)
File src/osmo-bsc-nat/bssap.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27471/comment/898f498d_b385a660 
PS1, Line 70: 	return bssap_ran_rcvmsg_udt(addr, msg, length - sizeof(struct bssmap_header));
...
Why is sizeof(struct bssmap_header) subtracted again here then?
Oh good point, that's a bug. Fixed it, thanks!
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27471
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc-nat
Gerrit-Branch: master
Gerrit-Change-Id: I3223409e25c93b625d67634caf68efe9772e2558
Gerrit-Change-Number: 27471
Gerrit-PatchSet: 4
Gerrit-Owner: osmith osmith@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Mon, 21 Mar 2022 15:37:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith osmith@sysmocom.de
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment