Attention is currently required from: Hoernchen, pespin.
fixeria has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email )
Change subject: core: fix config.h
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
if we add such a check to libosmocore gerrit build verification, then I am happy to accept the need […]
Just to clarify my idea, conditionally injecting `-DLIBOSMOCORE_NO_LOGGING` into `CPPFLAGS` in `configure.ac` achieves the same goal (turning logging macros into no-ops) as including `config.h` in each and every file. This way there's no need to enforce adding `config.h` everywhere.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic2cf52a3b60f43a2f5d3fe01c41a41f6fd9a8000
Gerrit-Change-Number: 42205
Gerrit-PatchSet: 4
Gerrit-Owner: Hoernchen
ewild@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: Hoernchen
ewild@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Thu, 26 Feb 2026 09:20:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen
ewild@sysmocom.de
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de