Attention is currently required from: fixeria, pespin.

clufn has posted comments on this change by clufn. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277?usp=email )

Change subject: Enable the use of an UE requested IP type and address to be used for gtpv2 PDN Address Allocation ......................................................................

Patch Set 3:

(2 comments)

File src/epdg_ue_fsm.erl:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277/comment/c16b0718_dccf6... : PS1, Line 264: Data1 = Data#ue_fsm_data{paa = conv:pdp_address_to_gtp2_paa(PdpTypeNr, PdpAddress), apn = Apn},

Yes that's be the preferred way imho.

Done

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277/comment/0d04e66b_4f912... : PS1, Line 353: Data#ue_fsm_data.paa,

I think it makes sense to pass PdpAddress and PfpTypeNr to create_session_req and do the conversion […]

Done