[M] Change in ...osmo-epdg[master]: Enable the use of an UE requested IP type and address to be used for ... - gerrit-log

12 May 2025

Attention is currently required from: fixeria, pespin.

clufn has posted comments on this change by clufn. (
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277?usp=email )

Change subject: Enable the use of an UE requested IP type and address to be used for gtpv2
PDN Address Allocation
......................................................................

Patch Set 3:

(2 comments)

File src/epdg_ue_fsm.erl:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277/comment/c16b0718_dccf…
:
PS1, Line 264:         Data1 = Data#ue_fsm_data{paa =
conv:pdp_address_to_gtp2_paa(PdpTypeNr, PdpAddress), apn = Apn},
...
  Yes that's be the preferred way imho. Done

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277/comment/0d04e66b_4f91…
:
PS1, Line 353:                                          Data#ue_fsm_data.paa,
...
  I think it makes sense to pass PdpAddress and
PfpTypeNr to create_session_req and do the conversion  […] Done

-- 
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: If0c77b1e366df36439d3a1b72030d831dd1b3a05
Gerrit-Change-Number: 40277
Gerrit-PatchSet: 3
Gerrit-Owner: clufn &lt;callumfarrbennett(a)yahoo.com&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Comment-Date: Mon, 12 May 2025 10:10:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Comment-In-Reply-To: clufn &lt;callumfarrbennett(a)yahoo.com&gt;