Attention is currently required from: osmith, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/31077 )
Change subject: modem: Initial integration of libosmo-gprs-rlcmac
......................................................................
Patch Set 1:
(3 comments)
File src/host/layer23/src/modem/llc.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/31077/comment/41f1ba74_48e175f9
PS1, Line 149: owneserip
ownership
Ack
https://gerrit.osmocom.org/c/osmocom-bb/+/31077/comment/e7cecd22_c7df4de3
PS1, Line 151: RLCMAC-GRR-UNITDATA-IND, we just need to adapt the header.
will this always be the case in the future? maybe it
makes sense to use osmo_static_assert on the si […]
comments are already there.
osmo_static_assert: I'll try that thanks.
File src/host/layer23/src/modem/rlcmac.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/31077/comment/ce19c296_e94ba21f
PS1, Line 78: LL
RLCMAC GMMRR
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/31077
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I0e628d9ddaa5ad6a205f07746d4176d1b8df7eb0
Gerrit-Change-Number: 31077
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Jan 2023 11:45:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment