Attention is currently required from: osmith.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36068?usp=email )

Change subject: gtp/gtp_internal.h: new file ......................................................................

Patch Set 1:

(1 comment)

File gtp/gtp_internal.h:

https://gerrit.osmocom.org/c/osmo-ggsn/+/36068/comment/e1c5d1ef_64a4f4b3 PS1, Line 3: int gtp_echo_resp(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, int fd, : void *pack, unsigned len); : int gtp_echo_ind(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, int fd, : void *pack, unsigned len); : int gtp_echo_conf(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, void *pack, unsigned len); : : int gtp_unsup_req(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, : int fd, void *pack, unsigned len); : int gtp_unsup_ind(struct gsn_t *gsn, struct sockaddr_in *peer, : void *pack, unsigned len); : : int gtp_create_pdp_resp(struct gsn_t *gsn, int version, : struct pdp_t *pdp, uint8_t cause); : : int gtp_create_pdp_ind(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, int fd, : void *pack, unsigned len); : : int gtp_create_pdp_conf(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, : void *pack, unsigned len); : : int gtp_update_pdp_req(struct gsn_t *gsn, int version, void *cbp, : struct in_addr *inetaddr, struct pdp_t *pdp); : : int gtp_delete_pdp_req(struct gsn_t *gsn, int version, void *cbp, : struct pdp_t *pdp); : : int gtp_delete_pdp_resp(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, int fd, : void *pack, unsigned len, : struct pdp_t *pdp, struct pdp_t *linked_pdp, : uint8_t cause, int teardown); : : int gtp_delete_pdp_ind(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, int fd, : void *pack, unsigned len); : : int gtp_delete_pdp_conf(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, : void *pack, unsigned len); why do those gtp_* symbols need to be non-static and declared in any header file at all? It looks to me like they are defined in gtp.c and the only user is in gtp.c itself?a