Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38037?usp=email ) Change subject: s1gw: add TC_pfcp_heartbeat ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38037/comment/2424ba62_da36… : PS2, Line 330: rts := f_pfcp_get_recovery_timestamp(); See my comment from last patch, you are also getting the value here, so you could have passed it to f_ConnHdlr_register_pfcp() above. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38037/comment/c6d8e0b8_f2e4… : PS2, Line 336: f_ConnHdlr_pfcp_expect(tr_PFCP_Heartbeat_Resp); (this function should probably return the actually received value matching the template.) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38037?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iadb24c2c346a62aa8b59d24475e71f683fc3dfe6 Gerrit-Change-Number: 38037 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Sep 2024 12:19:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes