Attention is currently required from: pespin, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27879 ) Change subject: rsl_rx_ccch_load: add explicit cast -1 to unsigned ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: was suggested by fixeria in the first comment, see above. I would go for UINT16_MAX or even the more readable 0xffff -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27879 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I02ad80e5d10f1a47cdf712f7f7c576a2e20fe607 Gerrit-Change-Number: 27879 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sat, 23 Apr 2022 12:57:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment