Attention is currently required from: daniel.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33685 )
Change subject: osmo_io: Document expectation that segmentation_cb() can modify msgb ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File include/osmocom/core/osmo_io.h:
https://gerrit.osmocom.org/c/libosmocore/+/33685/comment/a79d5a25_9e72b138 PS1, Line 50: will be trimmed to size i find it ambiguous: is this something that always happens before/after calling segmentation_cb(), or is segmentation_cb() expected to implement it? Possibly I'm just not familiar enough with segmentation, so feel free to ignore this review if appropriate. (I also don't understand whether segmentation_cb() splits up or joins messages from this doc...)