Attention is currently required from: laforge. keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28135 ) Change subject: sms_queue: Make deletion of messages from DB VTY-configurable ...................................................................... Patch Set 1: (1 comment) File src/libmsc/smsc_vty.c: https://gerrit.osmocom.org/c/osmo-msc/+/28135/comment/c8a92703_94b55f8e PS1, Line 82: "database delete-delivered (0|1)", I was thinking to make an sms node and move max-pending, max-failure here, which can currently only be changed at runtime. Also, why (0|1) and not the no delete-delivered logic? I don't want to hold it up, I can submit a subsequent patch with my ideas for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28135 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id6174875d5c01c40d987077651b27ae1acbcaa93 Gerrit-Change-Number: 28135 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: keith <keith(a)rhizomatica.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 17 May 2022 14:22:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment