Attention is currently required from: jolly.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33532 )
Change subject: mobile: Fix gsm_refer_pcs(): PCS can only be ARFCN 512..810 ......................................................................
Patch Set 2:
(1 comment)
File src/host/layer23/src/common/sysinfo.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/33532/comment/7a77fb85_7c46bd38 PS2, Line 65: (arfcn >= 512 && arfcn <= 810)
This would only allow cells in the DCS range to refer to cells with PCS frequencies. […]
I guess the only clean solution is to add one additional argument to the function (and document what it actually is supposed to do). That additional argument is the *arfcn of the cell through which we have received an ARFCN (assignment, SI, ...). In this case we can use the sending-cell-bcch-arfcn and the sending-cell-si1ro-band_ind to determine whether the ARFCN in question is PCS or not.