Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41477?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed: Verified+1 by Jenkins Builder

Change subject: sctp_{server,proxy}: handle sctp_error messages from gen_sctp ......................................................................

sctp_{server,proxy}: handle sctp_error messages from gen_sctp

The `{sctp_error, ...}` message is undocumented, but it does exist, and we have encountered it in production. The logic that generates `{sctp, ...}` and `{sctp_error, ...}` messages resides in Erlang/OTP's inet_drv.c, specifically in packet_binary_message() and sctp_parse_async_event(). Within sctp_parse_async_event(), an error is indicated by replacing the initial `sctp` atom with `sctp_error`.

Currently the following SCTP events are treated as errors:

* SCTP_SEND_FAILED (becomes #sctp_send_failed{}), * SCTP_REMOTE_ERROR (becomes #sctp_remote_error{}), * SCTP_PARTIAL_DELIVERY_EVENT (becomes #sctp_pdapi_event{}).

Print more specific messages when the sctp_error is received. Add new metrics for the above-mentioned SCTP events.

Change-Id: I38203d915d54dacd4e9bbf158ab86f8936585a34 Related: SYS#7738 --- M include/s1gw_metrics.hrl M src/s1gw_metrics.erl M src/sctp_common.erl M src/sctp_proxy.erl M src/sctp_server.erl 5 files changed, 41 insertions(+), 1 deletion(-)

git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/77/41477/2