neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33473 )

Change subject: hnbgw: drop dead code from MSC_UnitdataCallback ......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1: OK, I remember now.

a) not used: osmo-hnbgw has only recently started sending RANAP UnitData by its own initiative. Until very recently, osmo-hnbgw has only responded to receiving a RESET, with an ACK. It has never sent a RESET message to the peer, here titan. Also on RANAP, the HNBGW_Tests.ttcn so far conveniently ignored RANAP RESET handling. In short, this UnitDataCallback so far never happened.

b) makes no sense: The UnitDataCallback happens when osmo-hnbgw sends a RANAP UnitData to titan: so currently, in response to receiving any UnitData message, the code responds with a RESET. That is not logical at all.

(What would make sense: when receiving a RESET, respond with RESET ACK. But: Proper handling of RANAP RESET in ttcn actually happens in RAN_Emulation.ttcnpp)