Attention is currently required from: pespin, fixeria, daniel, dexter.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/29782
)
Change subject: Introduce support for libosmo-mgcp-client MGW pooling
......................................................................
Patch Set 3:
(2 comments)
File src/libmsc/call_leg.c:
https://gerrit.osmocom.org/c/osmo-msc/+/29782/comment/e7bac975_17403a24
PS3, Line 20: #include <asm-generic/errno-base.h>
why not errno.h?
File src/osmo-msc/msc_main.c:
https://gerrit.osmocom.org/c/osmo-msc/+/29782/comment/7784f242_0ad2adae
PS3, Line 561: , (ignoring MGW configuration in VTY node 'msc').
maybe only print this part, and maybe as warning, if there's actually a mgw
configuration in vty node msc?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/29782
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I7670ba56fe989706579224a364595fdd4b4708ff
Gerrit-Change-Number: 29782
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Oct 2022 10:50:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment