Attention is currently required from: canghaiwuhen, pespin.

fixeria has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email )

Change subject: Modified to dynamically adjust the returned QoS length to ensure compatibility with older modules. ......................................................................

Patch Set 6: Code-Review+1

(4 comments)

File src/sgsn/gprs_sm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/b1f05aa3_4306a799?usp... : PS1, Line 210: ANTIGRAVITY PATCH: True Echo.

What does this mean?

Done

https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/109b0034_71f18df4?usp... : PS1, Line 219: if (qos_len > sizeof(default_qos))

Done

https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/bd2ad1ca_c3de232c?usp... : PS1, Line 340: tp->lv[OSMO_IE_GSM_REQ_QOS].len

Done

File src/sgsn/gprs_sm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/95358616_721c2ccb?usp... : PS3, Line 221: msgb_lv_put(msg, qos_len, (uint8_t *)&default_qos);

let's better do: […]

Done