Attention is currently required from: lynxis lazus.
Jenkins Builder has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email )
Change subject: Re-introduce Iu/UTRAN support
......................................................................
Patch Set 3:
(2 comments)
File src/sgsn/gprs_ranap.c:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/1118ca2d_a1247a82?us… :
PS3, Line 219: if (new_area->cell_type != RANAP_IU_NEW_RAC) {
braces {} are not necessary for single statement blocks
File src/sgsn/gprs_routing_area.c:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/ea41fcc1_d51624f7?us… :
PS3, Line 439: } else {
else is not generally useful after a break or return
--
To view, visit
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I1b1aedd2a7c358bd388aa3d8a9f3c6a0011b4889
Gerrit-Change-Number: 40813
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 21 Aug 2025 16:38:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No