Attention is currently required from: laforge, dexter.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33511 )
Change subject: ASCI: Add call control for VGCS/VBS
......................................................................
Patch Set 14:
(1 comment)
File src/libmsc/msc_vgcs.c:
https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/22c52a11_b6b0ccb8
PS12, Line 224: static uint8_t _rx_callref(uint8_t *ie, unsigned int remaining_len, uint32_t *callref, bool *with_prio, uint8_t *prio)
the function still has an 'int' return type ?!?
It is int because it returns IE length or an error code.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/33511
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9947403fde8212b66758104443c60aaacc8b1e7b
Gerrit-Change-Number: 33511
Gerrit-PatchSet: 14
Gerrit-Owner: jolly
andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: dexter
pmaier@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Wed, 12 Jul 2023 08:51:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly
andreas@eversberg.eu
Comment-In-Reply-To: laforge
laforge@osmocom.org
Gerrit-MessageType: comment