Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30821 )

Change subject: bsc: Fix crash if PagingResponse with invalid MobileIdentity is received ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

File src/osmo-bsc/gsm_08_08.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/30821/comment/e891dee1_2c9f950b PS1, Line 443: if (conn->bsub) in general osmo-bsc code assumes that the subscriber is non-NULL, we can work around like this, but that probably needs similar checks in many other places to work out as intended.

my first impression is that we should ensure that conn->bsub is always valid (error out in 392 above).

or maybe making osmo-bsc safe to work without a subscriber is a more stable solution / better fits that a BSC "should" normally not parse DTAP at all?