fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38535?usp=email )

Change subject: s1gw_metrics: add a counter for unexpected PFCP PDUs ......................................................................

s1gw_metrics: add a counter for unexpected PFCP PDUs

Change-Id: I338662d0fe079f1c4222a70c5521eff2d237c793 --- M include/s1gw_metrics.hrl M src/pfcp_peer.erl M src/s1gw_metrics.erl 3 files changed, 4 insertions(+), 0 deletions(-)

Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve

diff --git a/include/s1gw_metrics.hrl b/include/s1gw_metrics.hrl index 1b54018..77d6a8e 100644 --- a/include/s1gw_metrics.hrl +++ b/include/s1gw_metrics.hrl @@ -8,6 +8,7 @@ -define(S1GW_CTR_PFCP_ASSOC_SETUP_RESP_RX, [ctr, pfcp, assoc_setup_resp, rx]). -define(S1GW_CTR_PFCP_ASSOC_SETUP_RESP_RX_ACK, [ctr, pfcp, assoc_setup_resp, rx_ack]). -define(S1GW_CTR_PFCP_ASSOC_SETUP_RESP_RX_NACK, [ctr, pfcp, assoc_setup_resp, rx_nack]). +-define(S1GW_CTR_PFCP_UNEXPECTED_PDU, [ctr, pfcp, unexpected_pdu]). -define(S1GW_CTR_S1AP_ENB_ALL_RX, [ctr, s1ap, enb, all, rx]). -define(S1GW_CTR_S1AP_ENB_ALL_RX_UNKNOWN_ENB, [ctr, s1ap, enb, all, rx_unknown_enb]). -define(S1GW_CTR_S1AP_PROXY_UPLINK_PACKETS_QUEUED, [ctr, s1ap, proxy, uplink_packets_queued]). diff --git a/src/pfcp_peer.erl b/src/pfcp_peer.erl index 1d266d1..a7e9515 100644 --- a/src/pfcp_peer.erl +++ b/src/pfcp_peer.erl @@ -222,6 +222,7 @@ {keep_state, S1}; _ -> ?LOG_NOTICE("Rx unexpected PFCP PDU: ~p", [PDU]), + s1gw_metrics:ctr_inc(?S1GW_CTR_PFCP_UNEXPECTED_PDU), {keep_state, S0} end;

@@ -269,6 +270,7 @@ {keep_state, S0}; _ -> ?LOG_NOTICE("Rx unexpected PFCP PDU: ~p", [PDU]), + s1gw_metrics:ctr_inc(?S1GW_CTR_PFCP_UNEXPECTED_PDU), {keep_state, S0} end;

diff --git a/src/s1gw_metrics.erl b/src/s1gw_metrics.erl index bba5209..55421e7 100644 --- a/src/s1gw_metrics.erl +++ b/src/s1gw_metrics.erl @@ -58,6 +58,7 @@ ?S1GW_CTR_PFCP_ASSOC_SETUP_RESP_RX, ?S1GW_CTR_PFCP_ASSOC_SETUP_RESP_RX_ACK, ?S1GW_CTR_PFCP_ASSOC_SETUP_RESP_RX_NACK, + ?S1GW_CTR_PFCP_UNEXPECTED_PDU, ?S1GW_CTR_S1AP_ENB_ALL_RX, ?S1GW_CTR_S1AP_ENB_ALL_RX_UNKNOWN_ENB, ?S1GW_CTR_S1AP_PROXY_UPLINK_PACKETS_QUEUED,