Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30125 ) Change subject: rtp_stream: allow multiple codecs to be set ...................................................................... Patch Set 1: Code-Review-1 (2 comments) Patchset: PS1: You say you postpone the "codec->codecs" rename (which is a good thing imho) but you seem to have forgot to split it from this patch. File src/libmsc/call_leg.c: https://gerrit.osmocom.org/c/osmo-msc/+/30125/comment/5f7a8727_7ab69152 PS1, Line 354: struct sdp_audio_codecs *codecs; This belongs to another patch IIUC according to the commit description (rename codec to codecs). -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30125 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If9c67b298b30f893ec661f84c9fc622ad01b5ee5 Gerrit-Change-Number: 30125 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 11:29:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment