Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918 )

Change subject: import latest e1-tracer host software ......................................................................

Patch Set 3:

(30 comments)

File software/e1-tracer/crc4itu.h:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/6bf3a4a5_d631d... PS3, Line 65: typedef uint_fast8_t crc_t; do not add new typedefs

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/4b45171b_2a21b... PS3, Line 75: return 0x0; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/ae5857e2_cd512... PS3, Line 98: return crc; please, no spaces at the start of a line

File software/e1-tracer/crc4itu.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/20fc2186_55f50... PS3, Line 26: 0x00, 0x03, 0x06, 0x05, 0x0c, 0x0f, 0x0a, 0x09, 0x0b, 0x08, 0x0d, 0x0e, 0x07, 0x04, 0x01, 0x02, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/b2cad587_c5d3e... PS3, Line 27: 0x05, 0x06, 0x03, 0x00, 0x09, 0x0a, 0x0f, 0x0c, 0x0e, 0x0d, 0x08, 0x0b, 0x02, 0x01, 0x04, 0x07, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/580bf650_b38d0... PS3, Line 28: 0x0a, 0x09, 0x0c, 0x0f, 0x06, 0x05, 0x00, 0x03, 0x01, 0x02, 0x07, 0x04, 0x0d, 0x0e, 0x0b, 0x08, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/9e6168ec_ef1c0... PS3, Line 29: 0x0f, 0x0c, 0x09, 0x0a, 0x03, 0x00, 0x05, 0x06, 0x04, 0x07, 0x02, 0x01, 0x08, 0x0b, 0x0e, 0x0d, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/eab3106a_33aa9... PS3, Line 30: 0x07, 0x04, 0x01, 0x02, 0x0b, 0x08, 0x0d, 0x0e, 0x0c, 0x0f, 0x0a, 0x09, 0x00, 0x03, 0x06, 0x05, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/97232727_45093... PS3, Line 31: 0x02, 0x01, 0x04, 0x07, 0x0e, 0x0d, 0x08, 0x0b, 0x09, 0x0a, 0x0f, 0x0c, 0x05, 0x06, 0x03, 0x00, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/227af2d5_ff3b6... PS3, Line 32: 0x0d, 0x0e, 0x0b, 0x08, 0x01, 0x02, 0x07, 0x04, 0x06, 0x05, 0x00, 0x03, 0x0a, 0x09, 0x0c, 0x0f, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/f71b5ae1_d7f60... PS3, Line 33: 0x08, 0x0b, 0x0e, 0x0d, 0x04, 0x07, 0x02, 0x01, 0x03, 0x00, 0x05, 0x06, 0x0f, 0x0c, 0x09, 0x0a, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/ab618b80_df986... PS3, Line 34: 0x0e, 0x0d, 0x08, 0x0b, 0x02, 0x01, 0x04, 0x07, 0x05, 0x06, 0x03, 0x00, 0x09, 0x0a, 0x0f, 0x0c, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/3bd84169_f27f6... PS3, Line 35: 0x0b, 0x08, 0x0d, 0x0e, 0x07, 0x04, 0x01, 0x02, 0x00, 0x03, 0x06, 0x05, 0x0c, 0x0f, 0x0a, 0x09, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/40432c78_2de47... PS3, Line 36: 0x04, 0x07, 0x02, 0x01, 0x08, 0x0b, 0x0e, 0x0d, 0x0f, 0x0c, 0x09, 0x0a, 0x03, 0x00, 0x05, 0x06, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/025e6803_be715... PS3, Line 37: 0x01, 0x02, 0x07, 0x04, 0x0d, 0x0e, 0x0b, 0x08, 0x0a, 0x09, 0x0c, 0x0f, 0x06, 0x05, 0x00, 0x03, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/a32254af_4a0d5... PS3, Line 38: 0x09, 0x0a, 0x0f, 0x0c, 0x05, 0x06, 0x03, 0x00, 0x02, 0x01, 0x04, 0x07, 0x0e, 0x0d, 0x08, 0x0b, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/80af002d_79bed... PS3, Line 39: 0x0c, 0x0f, 0x0a, 0x09, 0x00, 0x03, 0x06, 0x05, 0x07, 0x04, 0x01, 0x02, 0x0b, 0x08, 0x0d, 0x0e, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/7f2e716b_51c27... PS3, Line 40: 0x03, 0x00, 0x05, 0x06, 0x0f, 0x0c, 0x09, 0x0a, 0x08, 0x0b, 0x0e, 0x0d, 0x04, 0x07, 0x02, 0x01, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/fa5ec3d5_9e0f1... PS3, Line 41: 0x06, 0x05, 0x00, 0x03, 0x0a, 0x09, 0x0c, 0x0f, 0x0d, 0x0e, 0x0b, 0x08, 0x01, 0x02, 0x07, 0x04 please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/cecf3326_1a05a... PS3, Line 47: const unsigned char *d = (const unsigned char *)data; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/073a9839_19b98... PS3, Line 48: unsigned int tbl_idx; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/c3e64aaa_22e7d... PS3, Line 50: while (data_len--) { please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/01eb3ff0_724a7... PS3, Line 51: tbl_idx = (crc << 4) ^ *d; code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/eee3169e_d43e0... PS3, Line 51: tbl_idx = (crc << 4) ^ *d; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/ef453de0_5c25d... PS3, Line 52: crc = crc_table[tbl_idx] & 0xf; code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/7377ba3d_93dea... PS3, Line 52: crc = crc_table[tbl_idx] & 0xf; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/352b8244_09aab... PS3, Line 53: d++; code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/c41a79cc_3854a... PS3, Line 53: d++; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/4a68ad30_ca081... PS3, Line 54: } please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-575): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/34ab9a2c_ce5d6... PS3, Line 55: return crc & 0xf; please, no spaces at the start of a line