Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33173 ) Change subject: cnpool: add context_map_cnlink_lost() handling ...................................................................... Patch Set 4: (2 comments) File include/osmocom/hnbgw/context_map.h: https://gerrit.osmocom.org/c/osmo-hnbgw/+/33173/comment/92775ff8_2337b3d1 PS3, Line 70: MAP_SCCP_EV_CN_LINK_LOST, Scenario: - There are many individual SCCP connections to a given MSC, SCCP Connection-Oriented. - Then there we receive a single RANAP RESET, SCCP connection-less UDT. The connection-less RESET pre-empts all the many individual UE conns. When the MSC sends us a RESET, it tells us in a connection-less way that it has restarted, and we should no longer attempt to use any SCCP connection-oriented conns to that MSC that were active before = any connected SCCP CO to this peer are definitely lost. (There should be the usual SCCP teardown happening, worst case from inactivity timeouts, but in this situation we want to make sure to flush out previous state to start afresh with the newly restarted MSC.) It would be a misnomer / layer mixup to call this event RX_RESET, because this FSM is about a single UE's SCCP CO. Obviously the SCCP CO does not receive a RESET. Instead, the connection-less unitdata received a RESET, and in consequence, the SCCP CO are all now to be considered lost. idk, is _EV_RANAP_LOST any better? The same action would qualify for any other reason why we might want all SCCP CO to get lost with the least possible amount of wire activity; that's why i picked this more general name. _EV_RANAP_RESET is technically too specific. File src/osmo-hnbgw/context_map_sccp.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/33173/comment/63e08382_1ec6a77b PS3, Line 385: case MAP_SCCP_EV_CN_LINK_LOST: (see above) (let me resolve this one, so there is a single unresolved item for this CR aspect, above) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33173 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic0a6fcfb747dc093528ca2bd12a269ad390d465c Gerrit-Change-Number: 33173 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jun 2023 00:49:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment